search

openhatch / oh-mainline

The code that runs openhatch.org
http://openhatch.org
GNU Affero General Public License v3.0
242 stars 310 forks source link

convert django-http-proxy's Django migrations to South migrations #1773

Closed SanketDG closed 8 years ago

SanketDG commented 9 years ago

This was causing problem in migrations because Django's inbuilt migrations ( which was introduced in 1.7 ) was being used.

Running

./manage.py schemamigration httpproxy --initial

converted them back to South migrations.

1734

codecov-io commented 9 years ago

Current coverage is 78.60%

Merging #1773 into master will not affect coverage as of d9bc034

@@            master   #1773   diff @@
======================================
  Files           70      70       
  Stmts         5931    5931       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit           4662    4662       
  Partial          0       0       
  Missed        1269    1269

Review entire Coverage Diff as of d9bc034

Uncovered Suggestions

  1. +0.51% via ...mplatetags/search.py#49...78
  2. +0.35% via ...mplatetags/search.py#83...102
  3. +0.31% via ...file/view_helpers.py#186...203
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

ehashman commented 9 years ago

Good to see continuous integration passing.

I am going to do two tests:

  1. Test a clone and db init of the master branch in its current state.
  2. Test a clone and db init of this PR.

Presumably what will happen is I will get an error for 1. but succeed in case 2. And hopefully at that point I'd merge this. (I might not get around to this today, maybe tomorrow or Friday.)

I do want to flag @jwm though, as I am mildly confused as to why this has been fine in production but broke things for new deployments.

jwm commented 8 years ago

@ehashman Looking again at the previous comment I made in https://github.com/openhatch/oh-mainline/issues/1734#issuecomment-151324945, I'm not entirely sure why migrations worked fine for me. I was doing a lot of Heroku-related work, so maybe I added django-http-proxy after I'd done the production database migration.

In any event, I'm :grinning: that this will be resolved. These changes look good, and will hold us over until we upgrade to a version of Django with built-in migration support.

ehashman commented 8 years ago

Sorry it took so long for me to get around to testing this! John's email reminded me about this PR. Tests worked out great so I'm going to merge :)