openhealthcare / elcid

elCID deployment for UCLH
http://elcid.openhealthcare.org.uk
Other
7 stars 3 forks source link

The `Mine` Patient List's Add Patient does not work #1553

Closed fredkingham closed 6 years ago

fredkingham commented 6 years ago

In elcid adding a patient by the teams modal works.

Adding a patient via the Add Patient button does not work.

This is because the tagging schema is broken.

Side effects of this is that if you then try and add a model that you have added to mine to another team it will also be removed.

Solution, copy TaggedPatientListMetadata.to_dict and hard code in mine for the time being. https://github.com/openhealthcare/opal/blob/v0.10.0/opal/core/patient_lists.py#L333

davidmiller commented 6 years ago

As discussed elsewhere, can we at least attempt to convert Mine to be a TaggedPatientList rather than hardcoding it into the Opal field schema ?

@pacharanero might be worth a chat when you first pick this one up :)

GabPoll commented 6 years ago

seems ok to me. good job