search

openhealthcare / elcid

elCID deployment for UCLH
http://elcid.openhealthcare.org.uk
Other
7 stars 3 forks source link

Slight misalignment of radio buttons in lab tests modals #1587

Closed pacharanero closed 5 years ago

pacharanero commented 6 years ago

In the example below, the Rhinovirus radio buttons are just slightly out of line with the others.

image

As far as I can see this is because the Rhinovirus group is created using

{% radio field="MicrobiologyTest.rhinovirus" %}

whereas the others on that panel are being coded in HTML directly. There must be some small difference in how they are being handled, possibly just an extra space or missing space.

In the Inspector, all text in these radio buttons seems to have quite a lot of surrounding whitespace:

image

(it's the same for both kinds of radio button declaration)

fredkingham commented 6 years ago

@pacharanero great now that's one thing I'm never going to unsee.

We set radio buttons, essentially as float left with margin, ie they're independent. I'm not sure what the solution to this is.

I think it might be to move to bootstrap check boxes that we've been thinking about.

davidmiller commented 5 years ago

This is entirely valid, but pragmatically we're not going to fix this here any time soon - closing.