search

openhealthcare / elcid

elCID deployment for UCLH
http://elcid.openhealthcare.org.uk
Other
7 stars 3 forks source link

Native browser `alert()`s seem odd and should be replaced by Opal UI? #1592

Open pacharanero opened 6 years ago

pacharanero commented 6 years ago

There are a couple in this controller, but there may be others. Would we be able to make it so these alerts used a nicer-looking notification?

https://github.com/openhealthcare/elcid/blob/961aad5ab2475d22194ccf9a0b176a5f590f912e/walkin/static/js/walkin/controllers/walkin_hospital_number.js#L139

pacharanero commented 6 years ago

image

davidmiller commented 6 years ago

See also:

https://github.com/openhealthcare/opal/issues/751

And a first pass implementation:

https://github.com/openhealthcare/opal/commit/d551b8cf603220a5cef7da2e3e17409024e9d058