openhealthcare / whopaysthisdoctor.org

whopaysthisdoctor.org website
2 stars 6 forks source link

Upgrade to Python 3 #18

Open samsmith opened 5 years ago

samsmith commented 5 years ago

dependency wsgiref is incompatible with python 3. Alternates seem to be available, possibly in the py3 core library

davidmiller commented 5 years ago

If we're planning to keep this around, it's worth doing the housekeeping to upgrade Python, Django etc to latest versions. Lots are now quite old / unsupported. Should be straightforward, the app doesn't do anything clever.

samsmith commented 5 years ago

On 1 Jul 02019, at 16:06, David Miller notifications@github.com wrote:

If we're planning to keep this around, it's worth doing the housekeeping to upgrade Python, Django etc to latest versions. Lots are now quite old / unsupported. Should be straightforward, the app doesn't do anything clever.

Python 3.x Django latest (Incl. convert migrations) As a minimum address things with security alerts Make sure heroku deployments definitely still work (stop pinning them at 2.x) in the hackday repo, a bunch of this work has already been done (they replicated it to deploy to heroku). but yes to all

fredkingham commented 5 years ago

I'm afraid none of the above was done. Requirements were just pinned. As it was

a) a pain b) upgrading an application is not what anyone wants to do at a hackday as you don't get anything to show for it at the end, which is kind of the point of the whole hackday setup.

Much more suited to a sunny Wednesday morning.