search

openhealthworks / nhs-ideas-lab

Source for website
http://nhsideaslab.com
GNU General Public License v3.0
2 stars 2 forks source link

Hero layout bug fixes #96

Closed barneycarroll closed 6 years ago

barneycarroll commented 6 years ago

Fixes #19 & fixes #86

Mostly getting rid of a slider plugin invocations for the hero that seemed undesirable and caused layout bugs. Other minor hero fixes, video fallback image and some markup cruft cleanup.

This should cover all significant hero-related bugs.

Animations will be treated separately as there are cross-cutting concerns with orthogonal things like the page load doodad.

DeckOfPandas commented 6 years ago

i've lost track slightly, but the navbar responsiveness is still badly behaved -- is this expected?

e.g. navbar forced onto two lines at 1198px, menu totally disappears at 1138px then burger menu appears at 1023px

barneycarroll commented 6 years ago

Cool, as agreed I'll deal with that in a separate PR for #98