WIP: Regenerate modulefiles on update (fixes #1601)

openhpc / ohpc

OpenHPC Integration, Packaging, and Test Repo

http://openhpc.community

Apache License 2.0

856 stars 187 forks source link

WIP: Regenerate modulefiles on update (fixes #1601) #1984

Open opoplawski opened 4 months ago

opoplawski commented 4 months ago

This is as yet completely untested. But the idea is:

Split out the module generation into a separate script into a new bin directory. I think admins may want to run this at times as well
Update the script to only generate .rpmnew files if the files are different than the currently installed ones
Run that script whenever the /opt/intel/oneapi directory is updated by another rpm
Only run the %postun script when the package is completely removed, not on updates

Does the CI generate rpms that can be tested?

github-actions[bot] commented 4 months ago

Test Results

0 files - 14 0 suites - 14 0s :stopwatch: -6s 0 tests - 41 0 :white_check_mark: - 41 0 :zzz: ±0 0 :x: ±0 0 runs - 54 0 :white_check_mark: - 54 0 :zzz: ±0 0 :x: ±0

Results for commit e221feec. ± Comparison against base commit 792e7cd3.

:recycle: This comment has been updated with latest results.

adrianreber commented 4 months ago

Does the CI generate rpms that can be tested?

Yes, for each OS there should be an RPM attached to the GitHub Actions. The RPMs are only kept for 24 hours however, previously we reached space limits keeping them for a longer time.

Thanks for your PR. I will need at least one week before being able to look closer at this PR.

adrianreber commented 4 months ago

I would like to run new shell scripts through shellcheck. We have a https://github.com/openhpc/ohpc/blob/3.x/tests/ci/Makefile which does that for us. Could you add the new shellscript to the shellcheck, whitespace and shfmt sections there. If you prefer to not do these changes I can also do them later.

There is a similar script in the intel MPI compatibility package. I guess we should do the same changes there, right?

opoplawski commented 3 months ago

Am I right that shmft want TAB characters for indentation?

adrianreber commented 3 months ago

Am I right that shmft want TAB characters for indentation?

We just use the defaults that shfmt defines. The main goal is to be consistent. I never looked at the details.

Just running make -C tests/ci/ shfmt-lint should fix it.

github-actions[bot] commented 1 month ago

A friendly reminder that this PR had no activity for 30 days.