openhpc / ohpc

OpenHPC Integration, Packaging, and Test Repo
http://openhpc.community
Apache License 2.0
840 stars 185 forks source link

Fixup #1983: Please rpmlint and add missing dependencies #1987

Closed Thyre closed 1 month ago

Thyre commented 1 month ago

As described in #1983 after merging, there are a few issues while building the packages:

  1. Building OPARI2 fails because the awk script doesn't contain a correct shebang. This is caused by packages missing.

    [   64s] + /usr/lib/rpm/redhat/brp-mangle-shebangs
    [   64s] *** WARNING: ./opt/ohpc/pub/libs/gnu13/opari2/2.0.8/share/doc/opari2/example/lib/libpomp.la is executable but has no shebang, removing executable bit
    [   64s] *** ERROR: ./opt/ohpc/pub/libs/gnu13/opari2/2.0.8/libexec/pomp2-parse-init-regions.awk has shebang which doesn't start with '/' (-f)
    [   64s] error: Bad exit status from /var/tmp/rpm-tmp.aWrFUM (%install)

    To fix this, I've added the missing dependencies not only to OPARI2, but also the other packages. This is just to make sure that nothing else breaks we haven't noticed yet. The added packages are used in the configure step.

  2. rpmlint had some errors, see https://github.com/openhpc/ohpc/pull/1983#issuecomment-2146917587 To fix this, I added the failing parts to the rpmlintrc of each package, as done with other OpenHPC packages.

github-actions[bot] commented 1 month ago

Test Results

14 files  ±0  14 suites  ±0   6s :stopwatch: ±0s 41 tests ±0  41 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  54 runs  ±0  54 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit f56934a0. ± Comparison against base commit 333fa56f.