koomie
commented
5 years ago Thank you for the submission (and apologies for our delay in completing this review). The TSC has recommended to reject this submission until changes are made.
The primary issue that was brought up during the review is that the current distribution is shipping an embedded component that does not have an open-source license. As an open-source community project, we are unable to ship non open-source items so that is a blocking issue. Other discussion items focused on the mechanics of how a generic end-site would want to setup XDMoD in an OpenHPC environment? As we understand it, there is a data-collection component (additional items to scrape data on compute nodes) and an aggregation/web-hosted viewing component. We believe sites currently using XDMoD frequently setup a separate instance for the aggregation/web-server piece. In the current context of OpenHPC recipes, this would need to expand to document provisioning of a separate appliance for the XDMoD web instance. Or alternatively, if the intent is to install on an OpenHPC head node, there was some concern about XDMoD integrating with other existing http components running on the head node and that virtualhost configuration updates will likely be necessary to sort out first. Finally, the lack of associated test collateral was a concern - if some simple tests verifying data aggregation could be included via CLI mechanisms, this would allow for some coverage to be added to the OpenHPC test-suite.
Happy to discuss further if you would like to follow up on potential changes.
Software Name
Open XDMoD
Public URL
https://open.xdmod.org/8.0/index.html
Technical Overview
Open XDMoD is an HPC monitoring software product that allows HPC managers to determine usage, utilization, quality control, reporting and assists in providing user support.
Latest stable version number
8.0
Open-source license type
Open XDMoD is bundled with several other open source software libraries. The following libraries are licensed using non-commercial licenses. These software products are not free for commercial use. Highcharts, which is available under the Creative Commons Attribution-NonCommercial 3.0 license.
Relationship to component?
If other, please describe:
Build system
If other, please describe:
Does the current build system support staged path installations? For example:
make install DESTIR=/tmp/foo(or equivalent)Does component run in user space or are administrative credentials required?
Does component require post-installation configuration.
If yes, please describe briefly:
If component is selected, are you willing and able to collaborate with OpenHPC maintainers during the integration process?
Does the component include test collateral (e.g. regression/verification tests) in the publicly shipped source?
If yes, please briefly describe the intent and location of the tests.
Does the component have additional software dependencies (beyond compilers/MPI) that are not part of standard Linux distributions?
If yes, please list the dependencies and associated licenses.
Does the component include online or installable documentation?
If available online, please provide URL. https://open.xdmod.org/8.0/index.html
[Optional]: Would you like to receive additional review feedback by email?
Yes rldeleon@buffalo.edu
- [ X] yes - [ ] no