snmp_bc_set_hotswap_state() has a likely wrong test

openhpi2 / Open-HPI-base

Open HPI is an open source implementation of the SA Forum's Hardware Platform Interface (HPI). HPI provides an abstracted interface to managing computer hardware, typically for chassis and rack based servers

0 stars 1 forks source link

snmp_bc_set_hotswap_state() has a likely wrong test #2495

Open openhpi2 opened 11 years ago

openhpi2 commented 11 years ago

--- a/openhpi/trunk/plugins/snmp_bc/snmp_bc_hotswap.c +++ b/openhpi/trunk/plugins/snmp_bc/snmp_bc_hotswap.c @@ -140,7 +140,7 @@ SaErrorT snmp_bc_set_hotswap_state(void *hnd, return(SA_ERR_HPI_INTERNAL_ERROR); }

- if (resinfo->cur_state != SAHPI_HS_STATE_INSERTION_PENDING ||

if (resinfo->cur_state != SAHPI_HS_STATE_INSERTION_PENDING && resinfo->cur_state != SAHPI_HS_STATE_EXTRACTION_PENDING) { snmp_bc_unlock_handler(custom_handle); return(SA_ERR_HPI_INVALID_REQUEST);

Reported by: mbaldessari