openhpi2 / Open-HPI-base

Open HPI is an open source implementation of the SA Forum's Hardware Platform Interface (HPI). HPI provides an abstracted interface to managing computer hardware, typically for chassis and rack based servers

0 stars 1 forks source link

Use after free in ipmidirect #2501

Open openhpi2 opened 11 years ago

openhpi2 commented 11 years ago

We should not delete r and then remove it from the list as r has an undefined value then.

Index: plugins/ipmidirect/ipmi_con.cpp

--- plugins/ipmidirect/ipmi_con.cpp (revision 7544) +++ plugins/ipmidirect/ipmi_con.cpp (working copy) @@ -51,9 +51,9 @@ while( m_queue ) { cIpmiRequest r = (cIpmiRequest )m_queue->data;

m_queue = g_list_remove( m_queue, r ); + delete r;
m_queue = g_list_remove( m_queue, r ); } }

Reported by: mbaldessari

openhpi2 commented 11 years ago

*_ATTENTION_** This account is disabled and is no longer accessed by the recipient. Please remove it from your address book.

Thanks

Original comment by: tariqx

openhpi2 commented 9 years ago

Subsystem: --> OpenHPI Daemon
3.6.0: 3.2.x --> Future

Original comment by: dr_mohan

openhpi2 / Open-HPI-base

Use after free in ipmidirect #2501

Index: plugins/ipmidirect/ipmi_con.cpp

m_queue = g_list_remove( m_queue, r ); + delete r;