remove_interconnect() in oa_soap_plugins code bug

[openhpi2]

In plugins/oa_soap/oa_soap_re_discover.c we have the following bug in remove_interconnect(): if (hotswap_state == NULL) { err("Failed to get hotswap state"); event.event.EventDataUnion.HotSwapEvent.PreviousHotSwapState = SAHPI_HS_STATE_INACTIVE; }
else
event.event.EventDataUnion.HotSwapEvent.PreviousHotSwapState = hotswap_state->currentHsState;

event.event.EventDataUnion.HotSwapEvent.HotSwapState = SAHPI_HS_STATE_NOT_PRESENT;

if (hotswap_state->currentHsState == SAHPI_HS_STATE_INACTIVE) { <--- If hotswap_state was NULL above we segfault here /* INACTIVE to NOT_PRESENT state change happened due to

• operator action / event.event.EventDataUnion.HotSwapEvent.CauseOfStateChange = SAHPI_HS_CAUSE_OPERATOR_INIT; } else {
  / This state change happened due to surprise extraction */ event.event.EventDataUnion.HotSwapEvent.CauseOfStateChange = SAHPI_HS_CAUSE_SURPRISE_EXTRACTION; }

Reported by: mbaldessari

[openhpi2]

Good find. Thank you. We will fix this soon. We never hit this issue. Is there a tool that you have used to uncover this problem? If so let's know what is that tool.

Original comment by: dr_mohan

[openhpi2]

Fixed in #7531

Original comment by: dr_mohan

[openhpi2]

• status: open --> closed-fixed

Original comment by: dr_mohan

[openhpi2]

• Group: --> 3.2.1

Original comment by: dr_mohan

[openhpi2]

*_ATTENTION_** This account is disabled and is no longer accessed by the recipient. Please remove it from your address book.

Thanks

Original comment by: tariqx