oa_soap_get_hotswap_state() should check SAHPI_CAPABILITY_FRU

openhpi2 commented 9 years ago

s per as the changes made in he HPI B.03.01 Specification(section 7.9.13 page 238), the existing code in oa_soap_get_hotswap_state() at plugins/oa_soap/oa_soap_hotswap.c:

if (! (rpt->ResourceCapabilities & SAHPI_CAPABILITY_MANAGED_HOTSWAP)) { err("Resource does not have MANAGED_HOTSWAP capability"); return SA_ERR_HPI_CAPABILITY; }

Should be modified to

    if (! (rpt->ResourceCapabilities & SAHPI_CAPABILITY_FRU)) {
            err("Resource does not have SAHPI_CAPABILITY_FRU");
            return SA_ERR_HPI_CAPABILITY;
    }

For more details please refer bug #1487.

Reported by: openhpi2

openhpi2 commented 9 years ago

labels: --> HP c-Class Plugin
summary: oa_soap_get_hotswap_state() should check SAHPI_CAPABILITY_FRU instead of SAHPI_CAPABILITY_MANAGED_HOTSWAP --> oa_soap_get_hotswap_state() should check SAHPI_CAPABILITY_FRU
status: open --> closed-fixed
assigned_to: dr_mohan

Original comment by: dr_mohan

openhpi2 commented 9 years ago

Fixed in checkin #7635

Original comment by: dr_mohan

openhpi2 / openhpi_bug_test

oa_soap_get_hotswap_state() should check SAHPI_CAPABILITY_FRU #1879