search

openhwgroup / core-v-mcu

This is the CORE-V MCU project, hosting CORE-V's embedded-class cores.
https://docs.openhwgroup.org/projects/core-v-mcu
Other
169 stars 52 forks source link

Fix hard-coded address widths to `APB_FPGA_ADDR_WIDTH` #108

Closed zarubaf closed 3 years ago

zarubaf commented 3 years ago

@gmartin102 noticed a number of other places where the width is hardcoded [19:0]. They should probably be fixed to be APB_FPGA_ADDR_WIDTH also. Please @gmartin102 if you could address that in a separate pull request?

Reference #107

gmartin102 commented 3 years ago

@zarubaf I fixed a number of other address width issues in efpga_subsystem, Also included some other logic fixes in various files and fixed a number of utility files .. openocd and ioscript things. I will do a pull request against Quicklogic branch address-width

zarubaf commented 3 years ago

Please do so! Thanks!

gmartin102 commented 3 years ago

@zarubaf - I've executed a pull request, but it fails the verible format, but I can't tell why its complaining about. I did run the format script and I had difficulting getting the git-diff script run locally so I'm not sure how to correct the errors

zarubaf commented 3 years ago

Sorry @gmartin102 I've missed the PR. I've left some minor comments there.

MikeOpenHWGroup commented 3 years ago

Hi @gmartin102, what is the status of this issue?

MikeOpenHWGroup commented 3 years ago

Complete.