search

openhwgroup / core-v-mcu

This is the CORE-V MCU project, hosting CORE-V's embedded-class cores.
https://docs.openhwgroup.org/projects/core-v-mcu
Other
158 stars 50 forks source link

Fix the reference to the Verilator model patch up script. #315

Closed jeremybennett closed 10 months ago

jeremybennett commented 11 months ago 
* core-v-mcu.core: Update the directory with the vedit.sh script.
jeremybennett commented 11 months ago

This is a trivial mistake that's been lying around for months. I only missed it because I was using a legacy build directory which happened to have an old version in the correct place.

jeremybennett commented 11 months ago

This is a trivial mistake that's been lying around for months. I only missed it because I was using a legacy build directory which happened to have an old version in the correct place.

MikeOpenHWGroup commented 11 months ago

This looks like a good fix @jeremybennett, thanks. I see that pre_build_scripts is defined in two places: filesets:pre_build_scripts: and scripts:pre_build_scripts:. Just to I can reproduce the failure and fix, what command-line did you use?

jeremybennett commented 11 months ago

This looks like a good fix @jeremybennett, thanks. I see that pre_build_scripts is defined in two places: filesets:pre_build_scripts: and scripts:pre_build_scripts:. Just to I can reproduce the failure and fix, what command-line did you use?

I used make model-lib with Verilator 4.203

MikeOpenHWGroup commented 11 months ago

Hmmm. Something is not right. When I perform a fresh clone of this repo, the make model-lib command works as expected using Verilator 4.226. My commands:

$ git clone git@github.com:openhwgroup/core-v-mcu.git master
$ cd master
$ make model-lib

If I make the change in this PR to my local copy of core-v-mcu.core, the compile fails as follows:

INFO: Running pre_build script pre_build_scripts
sh: 0: cannot open src/openhwgroup.org_systems_core-v-mcu_0/rtl/core-v-mcu/scripts/vedit.sh: No such file
ERROR: Failed to build openhwgroup.org:systems:core-v-mcu:0 : pre_build script 'pre_build_scripts': ['sh', 'src/openhwgroup.org_systems_core-v-mcu_0/rtl/core-v-mcu/scripts/vedit.sh', 'openhwgroup.org_systems_core-v-mcu_0.vc'] exited with error code 2

I doubt (hope?) that the differences between Verilator v4.203 and v4.226 would not explain the differences...