openhwgroup / core-v-mcu

This is the CORE-V MCU project, hosting CORE-V's embedded-class cores.
https://docs.openhwgroup.org/projects/core-v-mcu
Other
168 stars 50 forks source link

RFC: Consolidate `apb_adv_timer` and `timer_unit` #66

Open zarubaf opened 3 years ago

zarubaf commented 3 years ago

I fail to understand why we would need to different timer units in the system. Can somebody enlighten me, please? @davideschiavone @timsaxe @gmartin102

gmartin102 commented 3 years ago

Florian, Te two timer directories are unique,. The timer_unit IP has the 2 32-bit / 1 64-bit timer that is used as the MTIMER for FreeRTOS. The apb_adv_timer is much more sophisticated in that it has state machines associated with it for PWM generation. I see the apb_adv_timer as the user general purpose timer resource as the timer_unit is probably;y reserved for the OS. In the timer_unit IP, there is a redundant file timer_unit.sv which utilizes an older register interface instead of the APB bus. I believe that file will disappear from the flattened repo structure.

Greg

On Apr 10, 2021, at 9:14 AM, Florian Zaruba @.**@.>> wrote:

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.

I fail to understand why we would need to different timer units in the system. Can somebody enlighten me, please? @davideschiavonehttps://github.com/davideschiavone @timsaxehttps://github.com/timsaxe @gmartin102https://github.com/gmartin102

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/openhwgroup/core-v-mcu/issues/66, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AP2QBU3LJ4V6TCSDSSCKQKLTIBMMFANCNFSM42WRSFRA.

zarubaf commented 3 years ago

Great, that makes sense. I’ll keep this open until we capture that information somewhere.

MikeOpenHWGroup commented 3 years ago

Hi @zarubaf, what is the status of this issue?

zarubaf commented 3 years ago

No news. It does not gate "v1".