search

openhwgroup / core-v-xif

RISC-V eXtension interface that provides a generalized framework suitable to implement custom coprocessors and ISA extensions
https://docs.openhwgroup.org/projects/openhw-group-core-v-xif/en
Other
53 stars 23 forks source link

Tweaking requirements around IDs #91

Closed christian-herber-nxp closed 7 months ago

christian-herber-nxp commented 8 months ago

... to be unique in flight, incremental wrapping, non-continuous

christian-herber-nxp commented 8 months ago

@jklockars: does this address your input?

jklockars commented 8 months ago

Fine with me, but it seems you are missing a word: The id values for in-flight offloaded instructions are required to be unique.

By the way, I see that the ID length is part of the interface specification. As long as it matches between the coprocessor and the core that is fine. But one or the other (well, certainly the coprocessor, at least) might have a preferred minimum size due to the number of possible in-flight operations - should it be mentioned how that is handled/documented, perhaps?

christian-herber-nxp commented 8 months ago

Fine with me, but it seems you are missing a word: The id values for in-flight offloaded instructions are required to be unique.

By the way, I see that the ID length is part of the interface specification. As long as it matches between the coprocessor and the core that is fine. But one or the other (well, certainly the coprocessor, at least) might have a preferred minimum size due to the number of possible in-flight operations - should it be mentioned how that is handled/documented, perhaps?

fixed in 510637f