openhwgroup / corev-binutils-gdb

GNU General Public License v2.0
9 stars 26 forks source link

Update Zc* to version 1.0.1 #65

Closed simonpcook closed 1 year ago

simonpcook commented 1 year ago

This updates the Zc* support as per the version 1.0.1 spec, using the Change history at the top of the document as a reference.

This also provides what I believe is a fix for the missing tables as discussed in #55

yulong18 commented 1 year ago

LGTM

linsinan1995 commented 1 year ago

The index range in match_cm_jt and match_cm_jalt also needs an update (maybe also needs a test for table jump instruction with an index range 32-64).

https://github.com/openhwgroup/corev-binutils-gdb/blob/55c50bbb5f2e209743486225dbd8da38f546d8ff/opcodes/riscv-opc.c#L285-L300

NandniJamnadas commented 1 year ago

I have reviewed this patch but I have yet to test it out.

jeremybennett commented 1 year ago

I have resolved both the comments raised by @linsinan1995 . So this commit is good to rebase and merge.