search

openhwgroup / cv-hpdcache-verif

Verification environment for the OpenHW Group's CORE-V High Performance Data Cache controller.
Apache License 2.0
6 stars 2 forks source link

PLRU related updates #10

Closed khandelwaltanuj closed 1 week ago

khandelwaltanuj commented 1 week ago 
There is are couple changes
1. In the case of a read miss, plru is updated when the refill response is received wihtout an error
2. In the case of CMO_PREFETCH hit, plru is updated (correction after an RTL bug fix)

Thanks Tanuj

khandelwaltanuj commented 1 week ago

Hello,

I performed following steps Step 1: From your project repository, check out a new branch and test the changes.

git checkout -b khandelwaltanuj-main main git pull git@github.com:khandelwaltanuj/cv-hpdcache-verif.git main Step 2: Merge the changes and update on GitHub.

git checkout main git merge --no-ff khandelwaltanuj-main git push origin main

bit I still cannot merge

Thanks and regards Tanuj Khandelwal

MikeOpenHWGroup commented 1 week ago

but I still cannot merge

Yeah, and I notice that the automatic conflict resolution tool on GitHub has also given up. :stuck_out_tongue_closed_eyes:

At this point I declare defeat. Your best strategy is to close this PR and start a new one. A couple of suggestions:

  1. Make sure your fork is up-to-date wrt to the upstream (openhwgroup) repo.
  2. Create a feature branch for this change and issue the new PR from khandelwaltanuj:my-feature-branch to openhwgroup:main.
khandelwaltanuj commented 1 week ago

OK @MikeOpenHWGroup

Thanks for this one.

Regards Tanuj