openhwgroup / cv32e40p

CV32E40P is an in-order 4-stage RISC-V RV32IMFCXpulp CPU based on RI5CY from PULP-Platform
https://docs.openhwgroup.org/projects/cv32e40p-user-manual/en/latest
Other
966 stars 424 forks source link

CVFPU RTL updates for implementation tools #1001

Open pascalgouedo opened 5 months ago

pascalgouedo commented 5 months ago

Hi @MikeOpenHWGroup & @davideschiavone

A new CVFPU PR related to implementation tools has been opened. Even if Synopsys Design Compiler didn't complain up to now, it seems Synopsys Fusion Compiler doesn't like those few SystemVerilog RTL lines. As this is quite an important point to be implementation tools friendly and this PR is updating 4 of CVFPU files, do we need to import those modifications in CV32E40P before v2 RTL Freeze? If yes, we have 2 solutions:

In both solutions we can make LEC with or without those modifications and create a new RTL tag if LEC is fine for all 7 configurations. On verification side this new CV32E40P tag could be used on simulation non-regressions but couldn't be used for RISC-V ISA Formal Verification as it would mean killing 19 days jobs (still running!) and launch them again.

Thank you to give your thought about that.

Pascal.

PS: By the way we already did that kind of updates for Siemens EDA Tessent which didn't like some decoder RTL lines.

davideschiavone commented 5 months ago

hi @pascalgouedo - the ideal solution would be revendorize cvfpu - not sure about the point you made about Formal Verification though - I agree it is not nice to kill 19 days.. but then that means we are an older RTL - However, if the new CVFPU is LEC with the old one, then it does not matter to me

pascalgouedo commented 5 months ago

Thank you for your feedback @davideschiavone .

Finally none of these 2 solutions will be possible before RTL Freeze because it would impact RTL Code Coverage reports, waiver files and even maybe requests a new code coverage gathering from scratch.