openhwgroup / cv32e40p

CV32E40P is an in-order 4-stage RISC-V RV32IMFCXpulp CPU based on RI5CY from PULP-Platform
https://docs.openhwgroup.org/projects/cv32e40p-user-manual/en/latest
Other
966 stars 423 forks source link

RTL Code Coverage Hole in fpnew_divsqrt_th_32 module line 287 and 288 for FPU configuration #1019

Open YoannPruvost opened 4 months ago

YoannPruvost commented 4 months ago

Component

Component:RTL

Issue Description

The condition for if statement line 287 of fpnew_divsqrt_th_32 was not covered during all the simulation non-regressions.

After analysis we suspected that this scenario was in fact unreachable. Siemens Questa Static formal tool was used to prove that this scenario was unreachable. For this scenario a dedicated assertion was written, named assert_unreachable_divsqrt_th_288.

All information necessary to reproduce and analyze our work with formal can be found in the ReadMe in the cv32e40p/scripts/formal folder

As it was too late to implement a fix in the RTL due to long RISC-V ISA Formal Verification runs and requiring to update all waivers files as well, it has been decided to waive this scenario hole in v2.

288-1 288-2