search

openhwgroup / cv32e40p

CV32E40P is an in-order 4-stage RISC-V RV32IMFCXpulp CPU based on RI5CY from PULP-Platform
https://docs.openhwgroup.org/projects/cv32e40p-user-manual/en/latest
Other
941 stars 412 forks source link

Restored v1 headers and added same header to new files. #964

Closed pascalgouedo closed 6 months ago

pascalgouedo commented 6 months ago

The change to rtl/cv32e40p_fp_wrapper.sv adds a new parameter (FPU_ADDMUL_LAT). I am not in a position to comment on that.

rtl/cv32e40p_fp_wrapper.sv has 2 new parameters (FPU_ADDMUL_LAT and FPU_OTHERS_LAT) with respect to v1 to replace package defines by top level parameters.

pascalgouedo commented 6 months ago

All but one of the files changes in this PR are updates to license headers. These look OK and I am approving this PR on that basis.

In fact I restored files to v1 headers because between v1 and now I already updated some of them to what I expected to be final headers. But by making diff between v1 and now you will finally see much less updated files, aligning to the excel list I sent to mattermost.

DBees commented 6 months ago

@pascalgouedo I have reviewed files with the help of your spreadsheet. My understanding is that in case of modified files from V1, you have updated the existing header to add your copyright and in the case of newly created files, you have created the license with Solderpad 2.1. It looks good to me, so I approve.