[BUG] VERILATOR_INSTALL_DIR is not set proprely in setup-env.sh

openhwgroup / cva6

The CORE-V CVA6 is an Application class 6-stage RISC-V CPU capable of booting Linux

https://docs.openhwgroup.org/projects/cva6-user-manual/

Other

2.3k stars 698 forks source link

[BUG] VERILATOR_INSTALL_DIR is not set proprely in setup-env.sh #2534

Open Mabdalshakour opened 1 month ago

Mabdalshakour commented 1 month ago

Is there an existing CVA6 bug for this?

[X] I have searched the existing bug issues

Bug Description

In setup-env.sh line 45, VERILATOR_INSTALL_DIR is set to "$ROOT_PROJECT"/tools/verilator which doesn't take the VERILATOR_HASH into account like what install-verilator.sh does in line 40, where it sets it to $ROOT_PROJECT/tools/verilator-$VERILATOR_HASH. That makes verilator unreachable except for running smoke-tests.sh. You can't source setup-env.sh as a standalone.

valentinThomazic commented 1 month ago

Maybe I am failing to see the issue but I don't see it on the current latest commit (https://github.com/openhwgroup/cva6/commit/ab2283c075db94499d791a0eef66da2449cc2c1b) since the verif/regress/install-verilator.sh script will install the binary in tools/verilator/bin which is the default path in the verif/sim/setup-env.sh script. Please confirm you are still encountering the issue on https://github.com/openhwgroup/cva6/commit/ab2283c075db94499d791a0eef66da2449cc2c1b