openhwgroup / cvw-arch-verif

The purpose of the repo is to support CORE-V Wally architectural verification
Other
4 stars 25 forks source link

Issue with Cryptography Instructions #285

Open Daniyal-R-A opened 2 weeks ago

Daniyal-R-A commented 2 weeks ago

Make sim is giving error, if two extensions have same instructions. But as suggested in the 000_RISCV_summary-bitmanip_amo.pdf "Zknd and Zkne (RV64 only): AES Key Schedule" has the same Instructions as shown below: image

Same issue with Zbkb extension as it saying that it "also includes rolw, rorw, rorrwi, Table I.23, which are instructions for Zbb RV64: image

Also no instructions are listed for Zbkc extension: image

davidharrishmc commented 2 weeks ago

These instructions that belong to multiple extensions only need to be tested once, so they don't need to be generated more than once. Let's keep this issue open. Once the tests are created, let's think about the best way to run the appropriate tests for the appropriate extensions.