openhwgroup / cvw

CORE-V Wally is a configurable RISC-V Processor associated with RISC-V System-on-Chip Design textbook. Contains a 5-stage pipeline, support for A, B, C, D, F, M and Q extensions, and optional caches, BP, FPU, VM/MMU, AHB, RAMs, and peripherals.
Other
265 stars 186 forks source link

nightly regression generates spurious lint error #824

Closed davidharrishmc closed 4 weeks ago

davidharrishmc commented 5 months ago

When nightly regression runs overnight, there is a lint error in the email report. It appears to be consistenlty on zba_rv32gc.

regression-wally test

Command used: python regression-wally --nightly

Failed Tests:

lint-wally --nightly | tee /extern/nightly/2024-06-04/cvw/sim/verilator/logs/all_lints.log (/extern/nightly/2024-06-04/cvw/bin/logs/lint-wally --nightly | tee /extern/nightly/2024-06-04/cvw/sim/verilator/logs/all_lints.log.log)

The error is in zba_rv32gc

harris@chips:/extern/nightly/2024-06-04/cvw/sim/verilator/logs$ more all_lints.log 
...
zaamo_rv32gc passed lint
zaamo_rv64gc passed lint
zalrsc_rv32gc passed lint
zalrsc_rv64gc passed lint
zba_rv32gc fails with lint errors or warnings
harris@chips:/extern/nightly/2024-06-04/cvw/sim/verilator/logs$      

However, running lint by hand does not produce a failure:

harris@chips:/extern/nightly/2024-06-04/cvw$ WALLY=/extern/nightly/2024-06-04/cvw
harris@chips:/extern/nightly/2024-06-04/cvw$ echo $WALLY
harris@chips:/extern/nightly/2024-06-04/cvw$ bin/lint-wally --nightly
...
zalrsc_rv64gc passed lint
zba_rv32gc passed lint
zba_rv64gc passed lint
...
All 384 lints run with no errors or warnings
davidharrishmc commented 5 months ago

Trying to run nightly_build.py at the command line into the /extern/nightlytest directory. Still seems to pass lint.

harris@chips:~/cvw/bin$ python nightly_build.py --path /extern/nightlytest --repository https://github.com/openhwgroup/cvw --target all --send_email ['harris@hmc.edu,kaitlin.verilog@gmail.com']
Cloning into '/extern/nightlytest/2024-06-05/cvw'...
remote: Enumerating objects: 73675, done.
remote: Counting objects: 100% (712/712), done.
remote: Compressing objects: 100% (291/291), done.
remote: Total 73675 (delta 429), reused 646 (delta 391), pack-reused 72963
Receiving objects: 100% (73675/73675), 38.11 MiB | 38.07 MiB/s, done.
Resolving deltas: 100% (50362/50362), done.
Submodule 'addins/FreeRTOS-Kernel' (https://github.com/FreeRTOS/FreeRTOS-Kernel.git) registered for path 'addins/FreeRTOS-Kernel'
Submodule 'addins/ahbsdc' (http://github.com/JacobPease/ahbsdc.git) registered for path 'addins/ahbsdc'
Submodule 'addins/branch-predictor-simulator' (https://github.com/ross144/branch-predictor-simulator) registered for path 'addins/branch-predictor-simulator'
Submodule 'addins/coremark' (https://github.com/eembc/coremark) registered for path 'addins/coremark'
Submodule 'addins/embench-iot' (https://github.com/embench/embench-iot) registered for path 'addins/embench-iot'
Submodule 'addins/riscv-arch-test' (https://github.com/riscv-non-isa/riscv-arch-test) registered for path 'addins/riscv-arch-test'
Submodule 'addins/riscv-dv' (https://github.com/google/riscv-dv) registered for path 'addins/riscv-dv'
Submodule 'addins/vivado-boards' (https://github.com/Digilent/vivado-boards/) registered for path 'addins/vivado-boards'
Cloning into '/extern/nightlytest/2024-06-05/cvw/addins/FreeRTOS-Kernel'...
remote: Enumerating objects: 174743, done.        
remote: Counting objects: 100% (16118/16118), done.        
remote: Compressing objects: 100% (1021/1021), done.        
remote: Total 174743 (delta 15275), reused 15404 (delta 15069), pack-reused 158625        
Receiving objects: 100% (174743/174743), 116.19 MiB | 32.75 MiB/s, done.
Resolving deltas: 100% (124770/124770), done.
Cloning into '/extern/nightlytest/2024-06-05/cvw/addins/ahbsdc'...
warning: redirecting to https://github.com/JacobPease/ahbsdc.git/
remote: Enumerating objects: 23, done.        
remote: Counting objects: 100% (23/23), done.        
remote: Compressing objects: 100% (15/15), done.        
remote: Total 23 (delta 8), reused 19 (delta 7), pack-reused 0        
Receiving objects: 100% (23/23), 17.86 KiB | 731.00 KiB/s, done.
...

harris@chips:/extern/nightlytest/2024-06-05/cvw/sim/verilator/logs$ more all_lints.log 
zknh_rv64gc passed lint
All 384 lints run with no errors or warnings
davidharrishmc commented 4 weeks ago

Abandoning this script.