openid-certification / oidctest

THE CERTIFICATION TEST SUITE HAS BEEN MIGRATED TO A NEW SERVICE https://www.certificatinon.openid.net
Other
50 stars 15 forks source link

Exception in OP-UserInfo-Header test with implicit (id_token+token) response type #104

Closed gliu0 closed 6 years ago

gliu0 commented 6 years ago

We got following exception in OP-UserInfo-Header test with Implicit (id_token+token) response type.

0.806 exception AttributeError:'NoneType' object has no attribute 'capitalize'

No request was made to our userinfo endpoint in this case. The same test works with other response types.

Also, OP-UserInfo-Body and OP-UserInfo-Endpoint work fine with the Implicit (id_token+token) response type.

It looks like an issue in the testing tool.

zandbelt commented 6 years ago

It seems your response is lacking the required token_type parameter when the access token is returned in the front channel. That follows out of the text in http://openid.net/specs/openid-connect-core-1_0.html#HybridAuthResponse although the non-normative example is wrong there. Adding the token_type parameter in your id_token+token OP response will fix this. On our side we'll handle:

<edit> the sample is ok because for code+id_token instead of id_token+token...

gliu0 commented 6 years ago

I see. Thank you very much Hans for looking into it!