search

openid-certification / oidctest

THE CERTIFICATION TEST SUITE HAS BEEN MIGRATED TO A NEW SERVICE https://www.certificatinon.openid.net
Other
49 stars 15 forks source link

replace underscores with hyphens in hostnames #138

Closed dannysauer closed 5 years ago

dannysauer commented 5 years ago

Underscores aren't RFC-legal characters in host names (although they are legal in other DNS entries and in the domain name portion of a FQDN), so using them can cause URL validation issues with particularly strict clients. This PR renames the hosts using a hyphen rather than the underscore, but leaves the underscore in the directory names and in similar references.

The two impacted sets of certs were regenerated using the modified script in PR #137 (and therefore conflicts with the underscore-bearing hostnames in that branch), so if this happens to be merged, it should probably be merged after that PR. :)

dannysauer commented 5 years ago

Whoops - PR to wrong fork. :man_facepalming: