Wrong type comparison in tests

openid-certification / oidctest

THE CERTIFICATION TEST SUITE HAS BEEN MIGRATED TO A NEW SERVICE https://www.certificatinon.openid.net

Other

50 stars 15 forks source link

Wrong type comparison in tests #145

Closed tpazderka closed 5 years ago

tpazderka commented 5 years ago

Code in oidctst.op.func.check_support is doing a wrong comparison of types. It is using == instead of using issubclass.

The simple comparison tests starts failing once pyoidc drops support for python 2. The returned type will be simple str and not a past.types.basestring.basestring.

Anyway basestring from future library doesn't seem to be properly subclassed as it can only be compared to instances. This is not true for six.string_types, so I would recommend using those.

tpazderka commented 5 years ago

https://github.com/OpenIDC/pyoidc/pull/595

zandbelt commented 5 years ago

this was deployed just now as part of OP 2.2.1 https://github.com/openid-certification/oidctest/releases/tag/v1.2.0