search

openid-certification / oidctest

THE CERTIFICATION TEST SUITE HAS BEEN MIGRATED TO A NEW SERVICE https://www.certificatinon.openid.net
Other
50 stars 15 forks source link

OP-BackChannel-RpInitLogout-no-state #159

Closed panva closed 5 years ago

panva commented 5 years ago

Status: 🔴

This test renders a 500 CherryPy err message and produces no logs.

500 Internal Server Error
The server encountered an unexpected condition which prevented it from fulfilling the request.

Powered by CherryPy 8.9.1
rohe commented 5 years ago

I think I've found and fixed this bug.

panva commented 5 years ago

Something else but still 🔴 

********************************************************************************

Something went wrong! If you know or suspect you know why, then try to
fix it. If you have no idea, then please tell us at certification@oidf.org
and we will help you figure it out.

********************************************************************************

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/oidctest-0.8.1-py3.6.egg/oidctest/optt/__init__.py", line 316, in _endpoint
    resp = self.tester.handle_request(request, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/otest-0.7.4-py3.6.egg/otest/aus/tool.py", line 257, in handle_request
    request_args=request_args)
  File "/usr/local/lib/python3.6/dist-packages/oidctest-0.8.1-py3.6.egg/oidctest/op/oper.py", line 652, in handle_request
    _info = self.parse_request(message_factory, request, request_args)
  File "/usr/local/lib/python3.6/dist-packages/oidctest-0.8.1-py3.6.egg/oidctest/op/oper.py", line 766, in parse_request
    req = self.deserialize(message_factory, request, request_args)
  File "/usr/local/lib/python3.6/dist-packages/oidctest-0.8.1-py3.6.egg/oidctest/op/oper.py", line 676, in deserialize
    req = req_cls(**msg_args)
TypeError: ABCMeta object argument after ** must be a mapping, not NoneType
panva commented 5 years ago

The tool now only renders the string "OK", but several errors appear in the log, altho those belong always to the previous run of the test. I've confirmed this by restarting the instance, in which case after getting "OK" there were no logs. Triggering the test again trigger a bunch of errors related to the mixed up tool state (client id and audience mixups).

rohe commented 5 years ago

I'll have a look at the logs.

rohe commented 5 years ago

Should return the user to the main page. Not just display "OK". Will fix.

rohe commented 5 years ago

Also have to look at the tool state.

rohe commented 5 years ago

I've checked in something that probably will handle the getting front/back channel logout request to an old (previous) client.

zandbelt commented 5 years ago

deployed now

panva commented 5 years ago

1) Nothing is being rendered any more but the test has no status and no logs. Regardless of whether its the first test ran after restart or not.

2) This has broken (same way as in 1) previously working case of OP-BackChannel-RpInitLogout-all

rohe commented 5 years ago

Damn! Ok, back to the drawing board.

panva commented 5 years ago

@rohe Do you still have the OP binary I built for you? Is that not sufficient for you to test these things locally? I'm fine taking the time to build you one that you can run and actually not develop blind, which is what i'm assuming is happening.

No ill intentions, just trying to be helpful and speed the rollout of these tests.

rohe commented 5 years ago

Don’t have the binary anymore.

If you could provide me with a binary that might help.

On 5 Apr 2019, at 18:58, Filip Skokan notifications@github.com wrote:

@rohe https://github.com/rohe Do you still have the OP binary I built for you? Is that not sufficient for you to test these things locally? I'm fine taking the time to build you one that you can run and actually not develop blind, which is what i'm assuming is happening.

No ill intentions, just trying to be helpful and speed the rollout of these tests.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openid-certification/oidctest/issues/159#issuecomment-480348555, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGGPEdgT0gIbMLJILCDYboZus8r4Uyvks5vd4DLgaJpZM4ceiBa.

— Roland Can anything be sadder than work left unfinished? Yes, work never begun. -Christina Rossetti, poet (5 Dec 1830-1894)