openid-certification / oidctest

THE CERTIFICATION TEST SUITE HAS BEEN MIGRATED TO A NEW SERVICE https://www.certificatinon.openid.net
Other
50 stars 15 forks source link

rp-key-rotation-op-sign-key rotates keys at invalid time #167

Open panva opened 5 years ago

panva commented 5 years ago

rp-key-rotation-op-sign-key-native

Request an ID Token and verify its signature. Will have to retrieve new keys from the OP to be able to verify the ID Token.

Successfully verify the ID Token signature, fetching the rotated signing keys if the 'kid' claim in the JOSE header is unknown.

rp-key-rotation-op-sign-key

Request an ID Token and verify its signature. Make a new authentication request and retrieve another ID Token and verify its signature.

Successfully verify both ID Token signatures, fetching the rotated signing keys if the 'kid' claim in the JOSE header is unknown.

The way I understand the descriptions

If this is not the case the tests are redundant, equal to one another.

If it is tho, both make the OP rotate keys when it issues the token exchange response and their descriptions are incorrect.

expected behaviour: rp-key-rotation-op-sign-key rotates right after issuing the first token exchange response so that the client can call its procedure. (similar to rp-key-rotation-op-enc-key)