openid / AppAuth-Android

Android client SDK for communicating with OAuth 2.0 and OpenID Connect providers.
https://openid.github.io/AppAuth-Android
Apache License 2.0
2.77k stars 873 forks source link

Change or skip allowed time skew for ID token issue time validation #1033

Open Mardaneus86 opened 5 months ago

Mardaneus86 commented 5 months ago

Checklist

Motivation and Context

Change aims to address issue in #830 by adding the ability to either disable or change the allowed time skew for the ID Token issued at time (iat). Changing the allowed time skew can be useful because the clock on some devices can go beyond the default of 10 minutes. The OIDC specs do not define a specific timeframe, and the default of 10 minutes is still used when the new options are not used.

Description

I followed a similar approach as #662 already did for skipping the issuer https check.

AppAuthConfiguration appAuthConfig = new AppAuthConfiguration.Builder()
    .setAllowedIssueTimeSkew(THIRTY_MINUTES_IN_SECONDS)
    .build()
AppAuthConfiguration appAuthConfig = new AppAuthConfiguration.Builder()
    .setSkipIssueTimeValidation(true)
    .build()
brighthr-stanton commented 5 months ago

This is a feature we've been waiting for for so long! Please review and accept, and we can move on from depending on v0.7.1 of the library :)

brighthr-stanton commented 4 months ago

Hi repo maintainers :) , Any news on this? Have been waiting for a month.... @WilliamDenniss @iainmcgin @StevenEWright

brighthr-stanton commented 3 months ago

agologan I see you seem to be one of the maintainers now? forgive me if I've misunderstood that. Any response to this PR please? We have been waiting a long time for this to be fixed.

sanduluca commented 2 months ago

Any news on this ?