openid / AppAuth-Android

Android client SDK for communicating with OAuth 2.0 and OpenID Connect providers.
https://openid.github.io/AppAuth-Android
Apache License 2.0
2.77k stars 873 forks source link

Improve error logging when sending the result via PendingIntent fails #1044

Open sheepmaster opened 4 months ago

sheepmaster commented 4 months ago

Update the error message not to mention cancelling, as the sendResult() method is used for sending the completion intent as well, and also include the exception stack trace.

Checklist

Motivation and Context

The sendResult() method is used for sending the completion intent as well as the cancellation intent, but its error message only mentions cancellation, which can be confusing. In addition, the additional exception parameter passed to Logger.error() is ignored.

Description

Update the error message not to mention cancelling, and also include the exception stack trace.

sheepmaster commented 3 months ago

Friendly ping?