updated completeAuthorizationRequest and query_string_utils parse to …

openid / AppAuth-JS

JavaScript client SDK for communicating with OAuth 2.0 and OpenID Connect providers.

Apache License 2.0

977 stars 162 forks source link

updated completeAuthorizationRequest and query_string_utils parse to … #115

Closed shockron22 closed 5 years ago

shockron22 commented 5 years ago

fixes https://github.com/openid/AppAuth-JS/issues/114

This function is only used in one location. Wouldn't it make more sense to update the function to be able to handle both routing types? Instead of having the user overload your internal function in the application code?

tikurahul commented 5 years ago

This will not work. URIs can have both fragments and query parameters. I don’t want to make this assumption.