search

openid / AppAuth-JS

JavaScript client SDK for communicating with OAuth 2.0 and OpenID Connect providers.
Apache License 2.0
985 stars 161 forks source link

Improve NPM experience #33 #34

Closed Meligy closed 7 years ago

Meligy commented 7 years ago

Fixes #33

Meligy commented 7 years ago

Can we please publish this if it's OK to merge?

Cheers,

Meligy commented 7 years ago

Good point about tests. They were added by mistake because I used a tool to generate the file.

I'll remove them and update the PR.

Regarding Node, let's include it the way it is for now. You already have good naming for them.

Ideally you'd want a neater import for these like import * as appAuthNode from '@openid/appauth/node_support';, but I don't know how to do this yet, and it seems not easy when you don't compile your TS files to the same folder, judging by https://github.com/Microsoft/TypeScript/issues/8305#issuecomment-343003095.

So what we have will work for now for Node.

Meligy commented 7 years ago

Check it now and let me know what you think. I deleted the tests references from the barrel.

tikurahul commented 7 years ago

Okay, this looks better. Can you also sign the CLA ?

https://github.com/openid/AppAuth-JS/blob/master/CONTRIBUTING.md

Meligy commented 7 years ago

Done for both 2 CLA documents.

Meligy commented 7 years ago

Also received an email from Mike Leszcz saying the signature was processed.