Closed Jenan closed 6 years ago
Please make sure you are using the latest versions of Typescript & React. Also try clearing your node_modules
folder and npm install
or yarn install
again.
After upgrading React and TS - I get this error:
node_modules/electron/electron.d.ts(5390,13): error TS2430: Interface 'WebviewTag' incorrectly extends interface 'HTMLElement'.
Types of property 'addEventListener' are incompatible.
Type '{ (event: "load-commit", listener: (event: LoadCommitEvent) => void, useCapture?: boolean | undef...' is not assignable to type '{ <K extends "error" | "waiting" | "progress" | "ended" | "change" | "input" | "select" | "abort"...'.
Types of parameters 'listener' and 'listener' are incompatible.
Type 'EventListenerOrEventListenerObject' is not assignable to type '(event: LoadCommitEvent) => void'.
Type 'EventListenerObject' is not assignable to type '(event: LoadCommitEvent) => void'.
Type 'EventListenerObject' provides no match for the signature '(event: LoadCommitEvent): void'.
https://github.com/googlesamples/appauth-js-electron-sample has been updated.
Also the issue you are seeing is being tracked here:
https://github.com/electron/electron-typescript-definitions/issues/79 https://github.com/styfle/magnemite/pull/11
It should not affect your ability to run the sample app.
I have tried to download the sample of implementation of AppAuth-JS with electron and after trying compiling I get this error:
How fix it? Thx.