search

openid / AppAuth-JS

JavaScript client SDK for communicating with OAuth 2.0 and OpenID Connect providers.
Apache License 2.0
977 stars 162 forks source link

Bug fix for implicit flow with # and auth code flow with ? url params #69

Closed ChinthakaSenanayaka closed 6 years ago

ChinthakaSenanayaka commented 6 years ago

This library works with implicit flow. But when I extend this library for PKCE, auth code from the URL was not extracted because of the limitation in URL param extraction by # marker only but not by ? query param.

tikurahul commented 6 years ago

Hi @ChinthakaSenanayaka. I am in the process of adding support for implicit flow, and changing some of the internals of redirect_request_handler. Sorry about the churn. That should make these kinds of changes unnecessary.

ChinthakaSenanayaka commented 6 years ago

It is OK, cool, but fix it and merge it soon.

We are in the process of writing extension library for this, we'd like to contribute to this OIDC library because we (WSO2 IAM Server middleware team) depend on this. Is there any process to join this community for contribution?

WilliamDenniss commented 6 years ago

ChinthakaSenanayaka, please sign the CLA for future PRs, otherwise your work can't be merged due to policy.

It looks like in this case Rahul is saying that this change won't be needed, as he is currently working on a separate change to add implicit flow support.