authStateByPresentingAuthorizationRequest seems to be broken on iPhone X simulator

openid / AppAuth-iOS

iOS and macOS SDK for communicating with OAuth 2.0 and OpenID Connect providers.

https://openid.github.io/AppAuth-iOS

Apache License 2.0

1.78k stars 776 forks source link

authStateByPresentingAuthorizationRequest seems to be broken on iPhone X simulator #141

Closed johnjcsmith closed 7 years ago

johnjcsmith commented 7 years ago

When attempting to use authStateByPresentingAuthorizationRequest in the iPhone X simulator, the SFSafariViewController appears to be broken.

This is not the case for the other simulators.

screen shot 2017-09-19 at 5 15 59 pm

WilliamDenniss commented 7 years ago

Does it work for you on real hardware (guess we can't with the X until November…)? The simulator is not always perfect. AppAuth 0.90 is running fine on my iPhone 6 with the iOS 11 GM seed.

btw. are you on the latest version? AppAuth on iOS 11 uses SFAuthenticationSession, not SFSafariViewController.

johnjcsmith commented 7 years ago

Ahh, My apologies.

Looks like I was using 0.8. 0.9 present's fine.