Open nuke-dash opened 5 years ago
Same here:
Fatal Exception: NSInvalidArgumentException 0 CoreFoundation 0x191f3698c __exceptionPreprocess 1 libobjc.A.dylib 0x19110f9f8 objc_exception_throw 2 CoreFoundation 0x191eb03f8 _CFArgv 3 CoreFoundation 0x191e210cc -[__NSArrayM insertObject:atIndex:] 4 AppAuth 0x10186aa80 -[OIDURLQueryComponent addParameter:value:] + 117 (OIDURLQueryComponent.m:117) 5 AppAuth 0x1018692cc -[OIDTokenRequest URLRequest] + 297 (OIDTokenRequest.m:297) 6 AppAuth 0x10185d170 +[OIDAuthorizationService performTokenRequest:originalAuthorizationResponse:callback:] + 433 (OIDAuthorizationService.m:433) 7 AppAuth 0x1018603e4 -[OIDAuthState performActionWithFreshTokens:additionalRefreshParameters:dispatchQueue:] + 513 (OIDAuthState.m:513) 8 AppAuth 0x101860178 -[OIDAuthState performActionWithFreshTokens:additionalRefreshParameters:] + 465 (OIDAuthState.m:465) 9 GTMAppAuth 0x1018a908c -[GTMAppAuthFetcherAuthorization authorizeRequestArgs:] + 235 (GTMAppAuthFetcherAuthorization.m:235) 10 GTMAppAuth 0x1018a9ed8 -[GTMAppAuthFetcherAuthorization authorizeRequest:completionHandler:] + 447 (GTMAppAuthFetcherAuthorization.m:447)
This is pretty serious - anyone doing anything about this? We've had 353 crashes reported in just 1 day and growing.
Same as this potentially? https://github.com/openid/AppAuth-iOS/issues/215
any luck on this issue? i am having same issue, NSURLComponents making query items and adding in paraneters without nil check
@wilmarvh {scheme = eclectic, user = (null), password = (null), host = (null), port = (null), path = /oauth2redirect, query = &code=192e421f-4b0b-11ee-a9a6-fa163eef2e72&state=xxkDWGnVa56Qr8SjUgaVHc0DwmVBjDLJyQM1ka7t9kE&offre_id=117, fragment = (null)} when adding these parameters, its crashing on OIDURLQueryComponent
Describe the bug When the redirect url contains an empty parameter the app crashes.
To Reproduce The redirect url should contain an empty parameters. Probably?paramter1=
I haven't been able to reproduce it myself as the server doesn't always give me a bad url.
Expected behavior Do not crash. Ignore the parameter.
Additional context The crash log See: 2 CoreFoundation 0x1b986ded -[__NSArrayM insertObject:atIndex:]
log.txt