Adds defines module to AppAuth.podspec

openid / AppAuth-iOS

iOS and macOS SDK for communicating with OAuth 2.0 and OpenID Connect providers.

https://openid.github.io/AppAuth-iOS

Apache License 2.0

1.75k stars 766 forks source link

Adds defines module to AppAuth.podspec #845

Closed mdmathias closed 6 months ago

mdmathias commented 6 months ago

Fixes #844

mdmathias commented 6 months ago

Waiting to merge based on result of Firebase/SpecStaging.

mdmathias commented 6 months ago

Merging since Firebase nightly tests look good with a similar gtm-session-fetcher change.

vonovak commented 5 months ago

Hello and thanks for this fix 🙂

Would it be possible to have this released (and also the change in gtm) soon?

There are downstream packages building on top of this, such as RN Google sign in and maybe Flutter and others that are hitting #844 and having this published would make it easy to use the latest versions. Thank you 🙂

mdmathias commented 5 months ago

@vonovak yes, the plan is to release this soon. I don't have a specific date to share because of privacy manifest work that I am responsible for elsewhere. I hope to get to this release in a week or two. Apologies for the delay.

I believe downstream clients can fix their issue -- by using use_frameworks! in their Podfile for example. I do think adding DEFINES_MODULE here is important since it means downstream clients do not need to make a fix on their own.