search

openid / OpenID4VCI

64 stars 18 forks source link

incorrect typ in proof type example #134

Closed jogu closed 8 months ago

jogu commented 9 months ago

The example proof jwt in https://openid.github.io/OpenID4VCI/openid-4-verifiable-credential-issuance-wg-draft.html#section-7.2.1.1 has "typ": "JWT" in the header, I think it should be "openid4vci-proof+jwt," as per https://openid.github.io/OpenID4VCI/openid-4-verifiable-credential-issuance-wg-draft.html#jwt-proof-type

selfissued commented 9 months ago

I agree. I could add this fix to PR #144 if people want me to.

Sakurann commented 8 months ago

fixing this in #128