search

openid / OpenID4VCI

62 stars 18 forks source link

[AS] `wallet_issuer` and `user_hint` requires accurate explaination about their scopes and usefulness #145

Open peppelinux opened 8 months ago

peppelinux commented 8 months ago

My colleagues and I never really understood the parameters wallet_issuer and user_hint and this PR doesn't solve that either. I think the specification is missing text on this, but unsure if this should be a target of this PR

Originally posted by @paulbastian in https://github.com/openid/OpenID4VCI/issues/142#issuecomment-1848953666

tplooker commented 8 months ago

I also don't believe we need yet another identifier for a wallet, especially if it is about identifying the wallet provider towards the credential issuer, because the credential issuer has the wallets client ID.

peppelinux commented 8 months ago

@tplooker my PR goes in this direction, where wallet_issuer is renamed to wallet_id

https://github.com/openid/OpenID4VCI/pull/142#issuecomment-1848953666

selfissued commented 8 months ago

This seems related to the discussion about whether to have a wallet identifier at all that is distinct from its Client ID. See issue #142.

Sakurann commented 6 months ago

I think both parameters were meant to facilitate using OID4VP during OID4VCI to obtain additional VCs from the user to authenticate the user. However, it is currently not very clear how those parameters gets passed from issuance flow to the presentation flow. might also be related to #20