Closed TakahikoKawasaki closed 8 months ago
last_name
to family_name
to align with 5.1. Standard Claims of OIDC Core 1.0.is_over_18
, is_over_21
, is_over_65
to age_over_18
, age_over_21
, age_over_65
, respectively, to align with "7.2.5 Age attestation: nearest "true" attestation above request" of "ISO/IEC 18013-5:2021".There are two proof_types_supported
in the draft. They should be changed to proof_types
.
Taka is of course right. This especially matters in cultures like Korea, where the first name pronounced is the family name. We should do this before the first Implementer's Draft.
I believe @selfissued fixed the two issues in E.3.2 (now moved to A.3.2 in the latest version of the spec).
https://github.com/openid/OpenID4VCI/pull/216 will fix the Japanese text.
The remaining issue to be resolved is the one in E.3.3 (now A.3.3):
vct should not be required because credential_configuration_id is sufficient. (Like doctype is no longer required in the case of mso_mdoc.)
per discussion in #217,
vct should not be required because credential_configuration_id is sufficient. (Like doctype is no longer required in the case of mso_mdoc.) The example JSON should contain credential_configuration_id and should not contain format and vct.
is now valid, so i think we can close this issue.
I agree, any fix for #217 will fix the remaining issue Taka raised. We can just close now right?
Editorial issues found in the working group draft built on December 22, 2023, published at https://openid.github.io/OpenID4VCI/openid-4-verifiable-credential-issuance-wg-draft.html
E.2.2. Credential Issuer Metadata, the example JSON
display[1].name
(在籍証明書) anddisplay[1].logo.alt_text
(大学のロゴ) are inappropriate. They mean "Certificate of Enrollment" and "Logo of University", respectively.E.3.2. Credential Issuer Metadata, the 1st paragraph
credentials_supported
->credential_configurations_supported
E.3.2. Credential Issuer Metadata, the example JSON
credentials_supported
->credential_configurations_supported
E.3.3. Authorization Details
vct
should not be required becausecredential_configuration_id
is sufficient. (Likedoctype
is no longer required in the case ofmso_mdoc
.)credential_configuration_id
and should not containformat
andvct
.