openid / OpenID4VCI

66 stars 19 forks source link

Editorial Issues in Appendix E.2 and E.3 #172

Closed TakahikoKawasaki closed 8 months ago

TakahikoKawasaki commented 9 months ago

Editorial issues found in the working group draft built on December 22, 2023, published at https://openid.github.io/OpenID4VCI/openid-4-verifiable-credential-issuance-wg-draft.html

E.2.2. Credential Issuer Metadata, the example JSON

E.3.2. Credential Issuer Metadata, the 1st paragraph

E.3.2. Credential Issuer Metadata, the example JSON

E.3.3. Authorization Details

TakahikoKawasaki commented 9 months ago

E.3.2. Credential Issuer Metadata, the example JSON

Others

There are two proof_types_supported in the draft. They should be changed to proof_types.

selfissued commented 9 months ago

Taka is of course right. This especially matters in cultures like Korea, where the first name pronounced is the family name. We should do this before the first Implementer's Draft.

jogu commented 8 months ago

I believe @selfissued fixed the two issues in E.3.2 (now moved to A.3.2 in the latest version of the spec).

https://github.com/openid/OpenID4VCI/pull/216 will fix the Japanese text.

The remaining issue to be resolved is the one in E.3.3 (now A.3.3):

vct should not be required because credential_configuration_id is sufficient. (Like doctype is no longer required in the case of mso_mdoc.)

Sakurann commented 8 months ago

per discussion in #217,

vct should not be required because credential_configuration_id is sufficient. (Like doctype is no longer required in the case of mso_mdoc.) The example JSON should contain credential_configuration_id and should not contain format and vct.

is now valid, so i think we can close this issue.

jogu commented 8 months ago

I agree, any fix for #217 will fix the remaining issue Taka raised. We can just close now right?