openid / OpenID4VCI

68 stars 20 forks source link

Batch Credential Response, description correction and improvement #273

Closed babisRoutis closed 8 months ago

babisRoutis commented 9 months ago

The protocol provides the following description:

The following parameters are used in the Batch Credential Response:

credential_responses: REQUIRED. Array that contains Credential Response objects, as defined in (#credential-request), and/or Deferred Credential Response objects, as defined in (#deferred-credential-request). Every entry of the array corresponds to the Credential Request object at the same array index in the credential_requests parameter of the Batch Credential Request. c_nonce: OPTIONAL. The c_nonce as defined in (#credential-response). c_nonce_expires_in: OPTIONAL. The c_nonce_expires_in as defined in (#credential-response).

I think there are two issues

Sakurann commented 9 months ago

thank you for spotting this. I think your observation is correct and we need a PR to fix this