openid / OpenID4VCI

68 stars 20 forks source link

clarify that tx_code parameter in the offer is not the code but requirements for it #334

Closed Sakurann closed 5 months ago

Sakurann commented 5 months ago

resolves #301.

In the token request can also add itself of something like below, but honestly felt redundant.

  • tx_code: OPTIONAL. String value containing a Transaction Code itself.
paulbastian commented 5 months ago

The proposal was actually about renaming the parameter. You think the cost/benefit ratio is not worth it?

Considering the Token Request text, I feel a better explanation could be the Transaction Code value, or as you mentioned itself

Sakurann commented 5 months ago

discussed in the WG, direction is to clarification and breaking change of a parameter name is not justified.

Sakurann commented 5 months ago

applied Paul's suggestion