search

openid / OpenID4VCI

68 stars 20 forks source link

Clarify language around opening Credential Offer Endpoint #380

Closed jogu closed 1 month ago

jogu commented 3 months ago

As per consensus on Oct-10-2022 working group call, the credential offer endpoint must be redirected to in order to allow the wallet to have a user interaction.

The languaged used is the same as used in RFC6749, but with resource owner changed to End-User for consistency with rest of VCI spec.

closes #13

closes #201

paulbastian commented 2 months ago

Could we move up the last sentence from this section ("The Credential Issuer MAY render a QR code containing the Credential Offer that can be scanned by the End-User using a Wallet, or a link that the End-User can click.") Reading this very common option in the last sentence, seems weird.

jogu commented 2 months ago

Could we move up the last sentence from this section ("The Credential Issuer MAY render a QR code containing the Credential Offer that can be scanned by the End-User using a Wallet, or a link that the End-User can click.") Reading this very common option in the last sentence, seems weird.

Yeah, I think that helps, I've done that.

jogu commented 2 months ago

This is ready for re-reviews please :)

paulbastian commented 2 months ago

This change just moved the existing line up to the top of the section. The underlying problem is that OpenID4VCI is missing a Wallet Invocation section like OpenID4VP, that could be linked here, I believe.

jogu commented 2 months ago

I've had another go based on Kristina's feedback and Paul's suggestion of having similar text to the wallet invocation section in VP. Please re-review!

jogu commented 1 month ago

4 approvals, open for over a month and mentioned on yesterday's WG call (and probably other WG calls too) without any objections being raised - merging - thanks everyone!