openid / OpenID4VCI

68 stars 20 forks source link

remove `claims` parameter from ISO mdoc and SD-JWT VC Credential Request #405

Closed paulbastian closed 2 weeks ago

paulbastian commented 1 month ago

Partly solves #151

Remove the claimsparameter from Credential Request for Credential Formats that support selective Disclosure anyway as this:

Sakurann commented 1 month ago

why removing only for mdoc and not other credential formats?

paulbastian commented 1 month ago

why removing only for mdoc and not other credential formats?

it is removed for all credential formats that have selective disclosure themselves, as from discussions that was the only reasoning this parameter was introduced (to enable a kind of selective disclosure for jwt-vc and alike)

Sakurann commented 1 month ago

noting that there is no agreement in the issue to remove this parameter. and this needs to be discussed before this can be merged.

paulbastian commented 1 month ago

Happy to discuss this in the working group call!

Sakurann commented 3 weeks ago

discussed in the WG, agreement to remove claims/credential_definition parameter for all credential formats from credential requests. but those parameters are kept for authorization details.

Sakurann commented 3 weeks ago

so this PR hopefully entirely resolves #151 because there is an agreement to keep claims in authorization_details and only remove it in credential request

Sakurann commented 2 weeks ago

during the hybrid WG call, agreed to remove all credential format specific claims from credential request. merging this PR since this PR was already ready to fulfill part of that agreement. There will be a follow up PR to complete what was agreed during a WG mtg - ie removing credential format specific claims from w3c vcdm format.