search

openid / OpenID4VP

58 stars 20 forks source link

fix: add wallet_unavailable error code; fixes #191 #200

Closed awoie closed 4 months ago

awoie commented 5 months ago

This PR adds an optional error code wallet_unavailable; fixes #191.

awoie commented 5 months ago

I think we probably need some more explanation in the specification text; it's not intuitive how this code is used and I think we need to mention the privacy/security concerns (as discussed on the issue) that the error code mustn't be returned without consent from the user.

That sounds good to me. I'll update the PR.

awoie commented 5 months ago

@peppelinux @jogu I updated the PR to incorporate your requested changes. Please review again.

jogu commented 4 months ago

Now has 3 reviews (many thanks @ssanchocanela!), all outstanding comments resolved and has been open for over a week - merging!