search

openid / OpenID4VP

47 stars 11 forks source link

Add further details of how errors are returned from Browser API including a example error response #204

Open jogu opened 4 days ago

jogu commented 4 days ago

As per @awoie comment here https://github.com/openid/OpenID4VP/pull/155/files#r1652002661:

It would make sense to add an error response example as well.

and @marcoscaceres comment here https://github.com/openid/OpenID4VP/pull/155/files#r1660602655:

Errors should probably result in promise rejections, no?

marcoscaceres commented 4 days ago

it would be good to discuss here and in the DC spec itself how we handle particular types of errors and response errors... we need to clarify what's "exceptional" (causing the promise to reject in the browser API), and what's expected as response data when there is some error.

jogu commented 4 days ago

I agree @marcoscaceres - it would probably be good to have a discussion about errors in a WICG call. I had a look and this issue from Rick is probably a place to discuss it: https://github.com/WICG/digital-credentials/issues/130

We may also need to update the example javascript call to the digital credential API in the VP spec depending on the outcome.