Include word (“CONDITIONAL”) in the other specs for VC (Verified Credentials)

OIDF-automation commented 1 year ago

Imported from AB/Connect bitbucket: https://bitbucket.org/openid/connect/issues/2005

Original Reporter: rajvdesh

In https://openid.net/specs/openid-4-verifiable-credential-issuance-1_0.html
”CONDITIONAL” is used for parameters where they exist, given certain conditions.

Would it be a good approach to include this word (“CONDITIONAL”) in the other specs for VC (Verified Credentials) at least?
e.g. in https://bitbucket.org/openid/connect/src/master/openid-4-verifiable-presentations/openid-4-verifiable-presentations-1_0.md

presentation_definition:
CONDITIONAL. A string containing a Presentation Definition JSON object. See (#request_presentation_definition) for more details. This parameter MUST be present when presentation_definition_uri parameter, or a scope value representing a Presentation Definition is not present.
presentation_definition_uri:
CONDITIONAL. A string containing an HTTPS URL pointing to a resource where a Presentation Definition JSON object can be retrieved. This parameter MUST be present when presentation_definition parameter, or a scope value representing a Presentation Definition is not present. See (#request_presentation_definition_uri) for more details.

‌

OIDF-automation commented 1 year ago

Imported from AB/Connect bitbucket - Original Commenter: KristinaYasuda

CONDITIONAL is not an RFC2119 keyword so we are actually trying to avoid using the term CONDITIONAL. I will do a PR replacing CONDITIONAL with OPTIONAL.

OIDF-automation commented 1 year ago

Imported from AB/Connect bitbucket - Original Commenter: rajvdesh

Ah! gotcha. I found it in https://openid.net/specs/openid-4-verifiable-credential-issuance-1_0.html and wondered if was a keyword and if it could be used elsewhere.

Thanks for sharing! Yup, a PR to replace “CONDITIONAL” in https://openid.net/specs/openid-4-verifiable-credential-issuance-1_0.html sounds good. And you can mark this Issue as “closed”.

Thanks again!

OIDF-automation commented 1 year ago

Imported from AB/Connect bitbucket - Original Commenter: KristinaYasuda

PR #604. Thank you!

OIDF-automation commented 1 year ago

Imported from AB/Connect bitbucket - Original Commenter: danielfett

We just discussed on the SIOP call that the proposed wording in https://bitbucket.org/openid/connect/pull-requests/604 does not really work, as it described the same element as “OPTIONAL… MUST NOT be present when…”; the MUST NOT contradicts the OPTIONAL. Similar wording is used in other places in the spec, so a more comprehensive PR needs to be prepared after the move to Github.

OIDF-automation commented 1 year ago

Imported from AB/Connect bitbucket - Original Commenter: KristinaYasuda

what was the alternative wording suggested, which was also adopted in ekyc-ida? REQUIRED. MUST NOTE be present when.. which is also kind of contradictory - required, but must not….

OIDF-automation commented 1 year ago

Imported from AB/Connect bitbucket - Original Commenter: danielfett

Anything that does not introduce contradictions works… e.g.:

REQUIRED if ….; MAY/MUST NOT be present otherwise.

‌

OIDF-automation commented 1 year ago

Imported from AB/Connect bitbucket - Original Commenter: KristinaYasuda

ah it is required **IF** that is important. because required. bust must not be present if is contradictory.

Sakurann commented 6 months ago

we removed any mention of "CONDITIONAL" in odi4vp/vci specs in favor of required IF kind of terminology.

openid / OpenID4VP