search

openid / OpenYOLO-Android

Android protocol for credential exchange and update - "You Only Login Once"
http://openid.net/wg/ac/
Apache License 2.0
115 stars 18 forks source link

Fixed bug where dependencies were not present in pom files. #114

Closed dxslly closed 7 years ago

dxslly commented 7 years ago

As raised in https://github.com/openid/OpenYOLO-Android/issues/113#issuecomment-333957355 the pom files in the 0.2.0 release did not contain dependencies. This is was caused by switching our declared dependency configurations from compile to api/implementation when we upgraded to Gradle 4.x. The Android maven plugin version we used was not compatible, but is as of version 2.0. See here for a thread on this issue.

codecov-io commented 7 years ago

Codecov Report

Merging #114 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #114   +/-   ##
=========================================
  Coverage     70.13%   70.13%           
  Complexity      463      463           
=========================================
  Files            65       65           
  Lines          2662     2662           
  Branches        253      253           
=========================================
  Hits           1867     1867           
  Misses          713      713           
  Partials         82       82

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1a608a1...633c54c. Read the comment docs.

StanKocken commented 7 years ago

LGTM